Conversation
This way, we can lazy-load / compute values that we don't already have at access time.
This commit relies on the existence of a particular sub-type of SpectrogramLoader being present, which breaks some of our assumptions. This functionality should probably be implemented some other way ... possibly via the registry?
(I think I accidentally didn't include this file in any earlier commits ... RIP)
keggsmurph21
commented
Jan 10, 2020
Comment on lines
+72
to
+83
| if self.spectrogram_file is None: | ||
| sound_file = self.get_sound_file() | ||
| if sound_file is not None: | ||
| try: | ||
| logger.debug( | ||
| "No spectrogram file found, trying to create from sound file" | ||
| ) | ||
| self.set_spectrogram_file( | ||
| ParselmouthLoader.from_sound_file(sound_file) | ||
| ) | ||
| except FileLoadError as e: | ||
| logger.warning(e) |
Collaborator
Author
There was a problem hiding this comment.
NOTE: This needs special attention, since it breaks some of our assumptions.
jonorthwash
force-pushed
the
master
branch
3 times, most recently
from
81d5a96 to
9d1c199
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for loading / generating / saving spectrograms.