Skip to content

Enforce strict .ograf.json file extension for manifest files #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Richardpwe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enforce strict .ograf.json file extension for manifest files #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions client/src/FileHandler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,18 +76,22 @@ class FileHandler extends EventEmitter {
async isManifestFile(filePath, getFileContents, strict) {
// Note: The file name requirement was first added ~2025-06-13 (*.ograf),
// and later (2025-07-02) changed to *.ograf.json.
if (strict) {
if (!filePath.endsWith('.ograf.json')) return null
}
// According to the OGraf specification, manifest files MUST end with .ograf.json

// Only support one of these extensions:
if (
!filePath.endsWith('.manifest') &&
!filePath.endsWith('.json') &&
!filePath.endsWith('.ograf.json') &&
!filePath.endsWith('.ograf')
)
return null
// Only support .ograf.json extension (as per specification)
if (!filePath.endsWith('.ograf.json')) {
// For backward compatibility, also support legacy extensions if not in strict mode
if (strict !== false) {
return null
}
// Legacy support: also check for old extensions
if (
!filePath.endsWith('.manifest') &&
!filePath.endsWith('.json') &&
!filePath.endsWith('.ograf')
)
return null
}

// Filter away some commonly known NOT manifest files:
if (
Expand Down