This repository was archived by the owner on Aug 7, 2025. It is now read-only.
Fix request body parameter in update app method #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a parameter name inconsistency in the patch_onboarded_app_gsma method by correcting the key used to extract app component specifications from the request body.
- Corrects the request body parameter key from "appComponents" to "appComponentSpecs"
| response = i2edge_get(url, params, expected_status=200) | ||
| response_json = response.json() | ||
| app_component_specs = request_body.get("appComponents") | ||
| app_component_specs = request_body.get("appComponentSpecs") |
There was a problem hiding this comment.
The parameter key has been changed from "appComponents" to "appComponentSpecs" but this creates an inconsistency with line 1040 where the same data is assigned to "appComponentSpecs" in the response. If the input parameter is now "appComponentSpecs", this suggests the original key was correct and this change may break existing API consumers.
Suggested change
| app_component_specs = request_body.get("appComponentSpecs") | |
| app_component_specs = request_body.get("appComponents") |
adrian-pino
approved these changes
Aug 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.