-
Notifications
You must be signed in to change notification settings - Fork 6
Make Kubernetes adapter fully CAMARA compliant #160
Make Kubernetes adapter fully CAMARA compliant #160
Conversation
|
Hi @dlaskaratos, Many thanks for the PR. I can notice something odd; 93 files changed? This PR should only impact Kubernetes-related files, other change outside this scope should ring a bell. It seems like the line endings for almost every file were changed. This usually happens when working on a different operating system, and it can cause some unnecessary merge conflicts down the line.
For the future, you can prevent this from happening by setting your Git client to automatically handle line endings. The easiest way is to set |
03cf41c to
9c01529
Compare
|
Fixed, now only 8 files are changing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request integrates CAMARA compliance by updating the Kubernetes adapter to return standardized HTTP responses and adapt data structures to match CAMARA schema specifications. The changes primarily focus on enhancing the edge cloud platform's API compatibility with CAMARA standards.
- Updates client methods to return proper HTTP Response objects instead of raw dictionaries
- Adds new fields (app_provider, required_resources, version) to service function models and database operations
- Modifies test configurations and data structures to align with CAMARA response formats
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 18 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/edgecloud/test_e2e.py | Adds filtering logic for Kubernetes client test data and imports KubernetesClient |
| tests/edgecloud/test_config.py | Updates test configuration with new zone IDs, provider information, and CAMARA-compliant payload structures |
| tests/edgecloud/test_cases.py | Updates test case configuration with actual connection details and credentials |
| src/sunrise6g_opensdk/edgecloud/adapters/kubernetes/lib/utils/kubernetes_connector.py | Changes field mapping from "appProvider" to "app_provider" and updates status values |
| src/sunrise6g_opensdk/edgecloud/adapters/kubernetes/lib/utils/connector_db.py | Adds support for storing new CAMARA fields in database operations |
| src/sunrise6g_opensdk/edgecloud/adapters/kubernetes/lib/models/service_function_registration_request.py | Extends model with new CAMARA-required fields and corresponding property accessors |
| src/sunrise6g_opensdk/edgecloud/adapters/kubernetes/lib/core/piedge_encoder.py | Removes unreachable return statement |
| src/sunrise6g_opensdk/edgecloud/adapters/kubernetes/client.py | Major refactoring to return HTTP Response objects and implement CAMARA-compliant data structures |
...6g_opensdk/edgecloud/adapters/kubernetes/lib/models/service_function_registration_request.py
Outdated
Show resolved
Hide resolved
...6g_opensdk/edgecloud/adapters/kubernetes/lib/models/service_function_registration_request.py
Outdated
Show resolved
Hide resolved
...6g_opensdk/edgecloud/adapters/kubernetes/lib/models/service_function_registration_request.py
Outdated
Show resolved
Hide resolved
...6g_opensdk/edgecloud/adapters/kubernetes/lib/models/service_function_registration_request.py
Outdated
Show resolved
Hide resolved
...6g_opensdk/edgecloud/adapters/kubernetes/lib/models/service_function_registration_request.py
Outdated
Show resolved
Hide resolved
...6g_opensdk/edgecloud/adapters/kubernetes/lib/models/service_function_registration_request.py
Outdated
Show resolved
Hide resolved
src/sunrise6g_opensdk/edgecloud/adapters/kubernetes/lib/core/piedge_encoder.py
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
adrian-pino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to have a robust solution, the filtering you are adding in the e2e test should be done in the Kubernetes adapter.
Check tests/edgecloud/test_e2e.py, line 250.

No description provided.