Skip to content
This repository was archived by the owner on Jun 25, 2025. It is now read-only.

Conversation

@adrianafdez
Copy link
Collaborator

This PR updates the keycloak node port and config data, as well as sets the repository name as an env variable for building the image.

@adrianafdez adrianafdez requested a review from Copilot June 3, 2025 08:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Keycloak port and realm configuration, inlines and renames federation-manager configuration, and makes the Docker image tag dynamic by using a lowercase repository environment variable.

  • Update test Keycloak realm path
  • Change Keycloak NodePort and inline federation-manager config
  • Introduce lowercase REPO_NAME env var for dynamic image tags in CI

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/test/init.py Adjust Keycloak token URL to use the updated realm name
src/deploy/keycloak.yaml Change Keycloak service NodePort from 30080 to 30081
src/deploy/federation-manager.yaml Inline config.cfg, fix resource names for Deployment and Service
.github/workflows/federation-manager.yml Add lowercase repo name step and update Docker build/push tags
Comments suppressed due to low confidence (3)

src/deploy/federation-manager.yaml:15

  • The block scalar content under config.cfg is not indented further than the key, which will break YAML parsing; indent all subsequent lines by at least two additional spaces.
config.cfg: >-

src/deploy/federation-manager.yaml:24

  • [nitpick] Both the Deployment and Service now share the exact same name; consider adding clear suffixes (e.g., -app and -svc) to avoid confusion.
  name: federation-manager

.github/workflows/federation-manager.yml:31

  • The Bash parameter expansion ${GITHUB_REPOSITORY@L} is not supported in the GitHub Actions runner; use ${GITHUB_REPOSITORY,,} to lowercase the repository name.
echo "REPO_NAME=${GITHUB_REPOSITORY@L}" >> ${GITHUB_ENV}

@adrianafdez adrianafdez merged commit bf5f3bf into SunriseOpenOperatorPlatform:main Jun 3, 2025
1 check failed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant