Open
Conversation
Upgrade Pipfile python version to 3.7
Added a if/else statement to determine if self.response gets set with a 401. This doesn't happen when GET follows the redirects.
Contributor
Author
mccartney
reviewed
Jul 7, 2020
sumologic/sumologic.py
Outdated
Comment on lines
46
to
48
| endpoint = self.response.url.replace('/collectors', '') # dirty hack to sanitise URI and retain domain | ||
| else: | ||
| endpoint = self.response.url.replace('/collectors', '') # dirty hack to sanitise URI and retain domain |
Contributor
There was a problem hiding this comment.
That's unnecessary code duplicaiton.
Contributor
Author
There was a problem hiding this comment.
Thanks for catching it. Updated code to remove it.
Contributor
Author
There was a problem hiding this comment.
Actually, reviewing the recent commit logs. This can be closed.
Per a code review, it was noted two lines were noted as being duplicate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #51