-
Notifications
You must be signed in to change notification settings - Fork 27
[WIP] [DE-DE] Add German language support #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hey, I would love to have german support for numbers in dicio. It would enable all the other skills. Is there anything I can help with? And thank you :) |
|
Same here. Any news/help needed? |
bda9e31 to
d54de33
Compare
|
Is there any progress, or should we try to continue the work by ourselves? |
|
It's been two years. I think it's safe to say this is not being worked on anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can someone approve "date_time" and all the .word files?
They are looking good to me.
I am looking into the other files too, but those are definitely okay
Manually translated with love
|
Thanks @sl1txdvd for your contribution! I am very sorry for coming back to it only now :-/. I have put very little attention on this repo until now, since I made changes to the interface a few times and I had plans to change it again to make it even more flexible (basically using the code in Dicio's skill input matching implementation), but in the end I likely won't do anything like that as it would be too complicated and give few benefits. I converted the code to Kotlin, rebased on master, and fixed some compilation issues. However, this PR does not implement the parser, which is the hardest part. Tests are also failing, here is a report from Android Studio: @sl1txdvd let me know if you still intend to work on this and implement the parser part. Otherwise I'll close this PR and advise other contributors to open a new PR (and point them here to copy over what was already implemented, like @numerfolt suggested). Btw, I now know a tiny bit of German so I might be able to help out a bit more ;-) |
This is a work in progress and not meant to be merged. I have to work on Java files next.