Open
Conversation
cjchanx
reviewed
Jun 12, 2024
Comment on lines
87
to
95
| MPL3115A2S_Config cfg {0}; | ||
| MPL3115A2S_Data_Config dcfg {0}; | ||
| MPL3115A2S_Int_Config icfg {0}; | ||
|
|
||
| cfg.altimeter_mode = 1; | ||
| cfg.os_ratio = MPL3115A2S_CTRL_OS32; | ||
| dcfg.enable_all_flags = 1; | ||
|
|
||
| MPL3115A2S_Init(&cfg, &dcfg, &icfg); |
Member
Author
There was a problem hiding this comment.
Oopsie forgot to commit
| enum AltimeterTaskRequests | ||
| { | ||
| ALTIMETER_REQUEST_NONE = 0, | ||
| ALTIMETER_REQUEST_POLL, // Poll Request |
Contributor
There was a problem hiding this comment.
the 2 tabs here are crazy
Comment on lines
+57
to
+61
| while (1) { | ||
|
|
||
| //Process commands in blocking mode | ||
| Command cm; | ||
| bool res = qEvtQueue->ReceiveWait(cm); |
Contributor
There was a problem hiding this comment.
According to the system design we should be polling the sensor and storing it in this task then the altitude task will poll this task when it wants data
| float marioTemperature; | ||
| float luigiPressure; | ||
| float luigiTemperature; | ||
| // float bowserPressure; |
Contributor
There was a problem hiding this comment.
umm more descriptive names?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.