Include .NET Framework 4.5 Target

[nickevansuk]

This library looks really great - and we're keen to include it as a dependency in ours.

Following on from #6 - although it would absolutely make sense to force all our SDK users up to 4.6.1, at the moment we're still supporting back to 4.5. It looks like this small component is the only piece that doesn't work with 4.5.

It would be super helpful if we could keep 4.5 in here - at least until there's a feature-based reason not to?

I've also bumped Json.NET at the same time.

Thanks so much for what you've built here!

[Romanx]

Hi there,

I'm sorry to say that we won't be accepting this. Stubble itself is netstandard2.0 since it simplifies our cross-platform story and while I appreciate many people have not moved on to net462 it's not a large upgrade and I would usually advocate for that as dotnet 5 will be based purely on the dotnet core codebase and it will soon be a requirement for actively developed code

Thank you for your contribution and if there's anything else we can help you with let us know

[Romanx]

I actually think I was a little hasty here. Stubble itself has not yet moved to be only netstandard2.0 and still includes net45.

I'll re-open this and have a think on if we want to support net45. Thanks for your contribution

[nickevansuk]

Thanks for considering @Romanx - many of the suppliers we work with in the cash-strapped sport and physical activity sector are still using old software running on-premise within environments they do not control - so even a .NET upgrade across all their clients is a major and costly undertaking.

Really appreciate your flexibility here, as allowing us to support .NET 4.5 with a couple lines of config implies a significant cost saving for our partners, who take a different view on the Microsoft support lifestyle (one famously is still maintaining a VB6 application in production !!)

I've forked and published this repo to https://www.nuget.org/packages/Stubble.Extensions.JsonNet.Net45/ for now with this PR applied, so that we can include it as a dependency in our library - works really well!

Hopefully the solution here could be as simple as just accepting the PR?

Really appreciate you thinking about this - let me know if we can help at all!

[Romanx]

There's some adjustment needed since the build will now fail on linux due to the dotnet 4.5 targeting pack not being available. We do this for stubble already so it should be a simple fix I'll aim to do today.

[nickevansuk]

Great news, thank you so much @Romanx !