Skip to content

fix(services): handle null CreatedBy for legacy services #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
james-cross merged 2 commits into from
Jan 28, 2026
Merged

fix(services): handle null CreatedBy for legacy services #104

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a481b07
fix(services): handle null CreatedBy for legacy services
james-cross Jan 28, 2026
cc2ec0d
Merge branch 'main' into staging
james-cross Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/controllers/serviceController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,9 +227,11 @@ export const updateService = asyncHandler(async (req: Request, res: Response) =>
}

// Prepare update data
// Use existing CreatedBy if available, otherwise fall back to current user
// (handles legacy services created before CreatedBy was required)
const updateData = {
...validation.data,
CreatedBy: existingService.CreatedBy,
CreatedBy: existingService.CreatedBy || req.user?._id || req.body?.CreatedBy || 'system',
DocumentModifiedDate: new Date()
};

Expand Down