-
-
Notifications
You must be signed in to change notification settings - Fork 36
Registry can be configured with erlang :ssl options #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Andrew Bruce <andrew.bruce@maersk.com>
|
Hey @sstoltze, thanks for your contribution. Is there a need for arbitrary settings? Since there is already 2 SSL options, I would rather go explicit setting exposed. It will allow not to worry about what take precedence and where and at the same time we can keep Elixir without leaking Erlang erlavro knowledge |
|
We had the need to figure out what settings we needed to set to get it to work 🙂 We needed to customise |
Strech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to open a general options to avoid re-implementing all SSL options 👍🏼
|
Thanks for the feedback. I've tried to incorporate your comments, let me know if there is anything else that would be helpful. |
|
Sorry for the long wait, I will be back on 10th February and prepare this branch to be merged. We still need more docs update in the readme. |
|
Thanks for your patience and support the new option was released as a part of v0.30 release |
|
Thank you for maintaining a great library 🥳 |
This allows passing in arbitrary SSL options to the registry, while preserving the existing behaviour and configurations.
We had some fun getting this library to work with an existing system out of our control, and needed to customise some other options than the existing supported ones. We figure this is a good compromise, allowing users direct access to the :ssl options used internally if they require it.
Thanks for a great library!