Skip to content

Conversation

@sstoltze
Copy link
Contributor

This allows passing in arbitrary SSL options to the registry, while preserving the existing behaviour and configurations.

We had some fun getting this library to work with an existing system out of our control, and needed to customise some other options than the existing supported ones. We figure this is a good compromise, allowing users direct access to the :ssl options used internally if they require it.

Thanks for a great library!

Co-authored-by: Andrew Bruce <andrew.bruce@maersk.com>
@Strech
Copy link
Owner

Strech commented Jan 21, 2025

Hey @sstoltze, thanks for your contribution. Is there a need for arbitrary settings?

Since there is already 2 SSL options, I would rather go explicit setting exposed. It will allow not to worry about what take precedence and where and at the same time we can keep Elixir without leaking Erlang erlavro knowledge

@Strech Strech added help wanted Extra attention is needed client API Anything related to the client API and its quality labels Jan 22, 2025
@sstoltze
Copy link
Contributor Author

We had the need to figure out what settings we needed to set to get it to work 🙂
We emulated the style of other elixir libraries (like ecto) that allow you to pass in arbitrary :ssl options to control your connection. That seems easier than reproducing all possible options in this library and having to keep them compatible and up to date.

We needed to customise :cacertfile, :customize_hostname_check and cert_keys to get our setup working. If you have a strong preference for keeping options explicit in this library, we would need to make those three settings possible to set somehow.

Copy link
Owner

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to open a general options to avoid re-implementing all SSL options 👍🏼

@sstoltze
Copy link
Contributor Author

Thanks for the feedback. I've tried to incorporate your comments, let me know if there is anything else that would be helpful.

@Strech
Copy link
Owner

Strech commented Feb 3, 2025

Sorry for the long wait, I will be back on 10th February and prepare this branch to be merged. We still need more docs update in the readme.

@Strech Strech merged commit ee9e536 into Strech:master Feb 17, 2025
9 checks passed
@Strech
Copy link
Owner

Strech commented Feb 17, 2025

Thanks for your patience and support the new option was released as a part of v0.30 release

@sstoltze
Copy link
Contributor Author

Thank you for maintaining a great library 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client API Anything related to the client API and its quality help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants