-
Notifications
You must be signed in to change notification settings - Fork 0
Main Branch Update with 2025 Stuff #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Justin is a super cool and rad dude :D |
No you |
J-The-Fox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I would possibly do is move everything to the root of the project. So instead of going ahead and having the 2024-2025 folder, the actual WPILib project is set up in just the root of the repository, instead of in a sub-folder. Unless you want me to do that in the other pull request first, as that also does fix the workflows
|
Hmmmm I could probably get around to that at the end of this practice. I've just made a few changes that whenever I get the current thing in a solid state, I'd like to review what I've changed, and I can't really do that if I move that folder |
|
That would work for me as well. I can also help with some of the code in that regard if you need It doesn't have to be something we do right at this moment, but it is something that I would like to be done before hand. There's some organizational, and a few actual programming benefits to having this repository just hold this single project |
…Vy's desired buttons
…he AlgaeArmSubsystem file to use StartEnd Commands -H
… to sim settings -H
…al simulation) -H
…maplesim still won't pop up tho - H
|
One thing I may go ahead and do is get the necessary workflows in this branch just so the workflows are working properly instead of just stalling forever like they are doing here. Though I will work on the linting workflow separately in the workflow-testing branch as there is still some configuration I need to set up (and run by you as well) |
…used code in Elevator Subystem
J-The-Fox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like what I am seeing so far, however there is an issue with the gradle build that should be addressed.
You appear to be missing the <project-root>/.wpilib/wpilib_preferences.json and <project-root>/gradle/wrapper/gradle-wrapper.jar files.
These are crucial to be able to build the project. The wpilib_preferences.json file holds settings including the wpilib version for update control, the current project language, and the project team number, which is needed to build and deploy code. The gradle-wrapper.jar is used as a wrapper for gradle, without it, you get a Class Not Found during build and deploy.
This most likely is an issue with the .gitignore file, and should be addressed
|
One thing that you can change with this is by adding the same change that was made in the Limelight_Autoalign_Test branch. These are the following lines I would append to your You can also add |
Henry - This is more of a test for me as I figure out how Github works. This pull request contains all of the changes I have made thus far to the main branch. Fair warning, It is not organized well and there ain't no way a lot of this will be passing the status checks, but here ya go!