Remove useless awaits that cause application crashes#29
Open
bitbonk wants to merge 2 commits intoStephenCleary:masterfrom
Open
Remove useless awaits that cause application crashes#29bitbonk wants to merge 2 commits intoStephenCleary:masterfrom
bitbonk wants to merge 2 commits intoStephenCleary:masterfrom
Conversation
bitbonk
changed the title
| { | ||
| // We cannot use `when (ex.CancellationToken == cancellationToken)` on the catch block because the user delegate may be cancelled by a linked CancellationToken. | ||
| } | ||
| await executeAsync(parameter, _context.Token); |
There was a problem hiding this comment.
It looks like you accidentally included this code change in the wrong PR. This looks like a copy of the changes in #31, which are not relevant here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28
I don't see why
Execution.Taskneeds to be awaited again, becauseExecution.TaskCompletedwas already awaited.