Remove only_one_promotion_per_product validate form #3
Open
miyazawadegica wants to merge 1 commit intoStemboltHQ:1-3-stableishfrom
Open
Remove only_one_promotion_per_product validate form #3miyazawadegica wants to merge 1 commit intoStemboltHQ:1-3-stableishfrom
miyazawadegica wants to merge 1 commit intoStemboltHQ:1-3-stableishfrom
Conversation
promotion/rules/product.rb. Because we would like to create multi coupons against same product. But, currently we can not.So, remove its validation. For remove it, I refered to the following pull request. [Reference] spree#1984
cbrunsdon
pushed a commit
that referenced
this pull request
Aug 20, 2014
Believe or not but I struggled a bit with adding my own calculator to spree. As some other folks: #1: http://grokbase.com/t/gg/spree-user/141amnc5ns/creating-spree-extension-uninitialized-constant #2: http://stackoverflow.com/questions/5119960/how-to-properly-load-a-handmade-extension-in-spree #3: https://www.ruby-forum.com/topic/4403156 It's all about naming convention so why not give example just in case someone forgot it (as I did!)
shioyama
pushed a commit
to shioyama/spree
that referenced
this pull request
Oct 5, 2015
This was earlier proposed in StemboltHQ#3 but closed because it seemed dangerous. After looking more carefully at the issue involved I think we can do this and it will help make promotions much more flexible.
shioyama
pushed a commit
to shioyama/spree
that referenced
this pull request
Nov 19, 2015
This was earlier proposed in StemboltHQ#3 but closed because it seemed dangerous. After looking more carefully at the issue involved I think we can do this and it will help make promotions much more flexible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
promotion/rules/product.rb.
Because we would like to create multi coupons against same product.
But, currently we can not.So, remove its validation.
For remove it, I refered to the following pull request.
[Reference]
spree#1984