Restore scroll-to-top on route navigation with proper cleanup

[Copilot]

Router navigation event subscription was removed in commit f4b446f, breaking automatic scroll-to-top behavior when navigating between CV sections.

Changes

• Restored Router subscription: Re-added router.events subscription filtered by NavigationEnd to call window.scrollTo(0, 0) on route changes
• Lifecycle management: Implemented OnDestroy to unsubscribe from both router and languageChanged subscriptions, preventing memory leaks
• Fixed decorator placement: Moved GeneralData interface definition before @Component decorator to resolve TypeScript compilation errors

this.routerSubscription = this.router.events
  .pipe(filter(event => event instanceof NavigationEnd))
  .subscribe(() => {
    window.scrollTo(0, 0);
  });

ngOnDestroy() {
  this.routerSubscription?.unsubscribe();
  this.languageSubscription?.unsubscribe();
}

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• googlechromelabs.github.io
  • Triggering command: /usr/local/bin/node node install.mjs (dns block)
• https://storage.googleapis.com/chrome-for-testing-public/143.0.7499.169/linux64/chrome-headless-shell-linux64.zip
  • Triggering command: /usr/local/bin/node node install.mjs (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[Copilot]

Pull request overview

This PR restores the scroll-to-top functionality when navigating between CV sections, which was previously removed in commit f4b446f. The implementation adds manual router event subscription with proper lifecycle management.

• Restored router subscription to trigger window.scrollTo(0, 0) on NavigationEnd events
• Implemented OnDestroy lifecycle hook with cleanup for both router and language service subscriptions
• Fixed TypeScript interface placement by moving GeneralData interface before the @component decorator

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/app/app.component.ts	Adds router subscription for scroll-to-top behavior, implements OnDestroy for subscription cleanup, and fixes interface placement issue
.gitignore	Excludes package-lock.json to prevent conflicts with Yarn-based dependency management

[Copilot]

The ngOnDestroy lifecycle hook is unlikely to be called for the root AppComponent in a typical Angular application. The root component is only destroyed when the entire application shuts down (e.g., closing the browser tab), at which point all resources are automatically released by the browser. While implementing ngOnDestroy shows good practice for subscription cleanup, the unsubscribe calls here will effectively never execute in production.

For the root component, subscription cleanup is not critical since the subscriptions will live for the application's entire lifetime. However, if this pattern is intended to be educational or for consistency, it's acceptable to keep.

[Copilot]

Consider using Angular Router's built-in scroll restoration feature instead of manually subscribing to router events. You can configure this in the RouterModule by adding the scrollPositionRestoration option:

In app-routing.module.ts, modify the RouterModule.forRoot() call:
RouterModule.forRoot(routes, {
preloadingStrategy: PreloadAllModules,
scrollPositionRestoration: 'top'
})

This approach is more declarative, doesn't require subscription management, and is the recommended Angular way to handle scroll-to-top behavior on navigation. It would eliminate the need for the router subscription in the constructor and the routerSubscription property.