Bump to Spring Boot 3.5, add non-docker build script #48
Conversation
…ka, sba deps - also convert all .adoc to .md
- use metadata/IMAGE_VERSION as source of truth, also read it in fewer places - use lazy-initialization in eureka to improve start time
…t version to metadata - add build.ps1 to workflow triggers - remove bash script
bart-vmware
left a comment
bart-vmware
left a comment
There was a problem hiding this comment.
I haven't tried to run anything yet; initial feedback is based on browsing through the diff.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
- Pass a couple more properties to Initializr - Remove spring.config.name override - Opt out of cloud native binding support - Exclude "-temp" folders from supported images list
|
To run the UAA server image built for this pull request: docker run --rm -d --pull=always -p 8080:8080 --name uaa-pr steeltoe.azurecr.io/uaa-server:pr-48 |
|
To run the Eureka server image built for this pull request: docker run --rm -d --pull=always -p 8761:8761 --name eureka-pr steeltoe.azurecr.io/eureka-server:pr-48 |
|
To run the Spring Cloud Config Server image built for this pull request: docker run --rm -d --pull=always -p 8888:8888 --name config-pr steeltoe.azurecr.io/config-server:pr-48 |
|
To run the Spring Boot Admin server image built for this pull request: docker run --rm -d --pull=always -p 9099:9099 --name sba-pr steeltoe.azurecr.io/spring-boot-admin:pr-48 |
|
Please add the .vs directory to 
|
What opened in Visual Studio? There's nothing .NET in this repo, so this isn't something I would expect |
I opened the folder to get colorization on the script. |
- add VS and VS Code folders to .gitignore - put versions in artifact name
|
To run the UAA server image built for this pull request: docker run --rm -d --pull=always -p 8080:8080 --name uaa-pr steeltoe.azurecr.io/uaa-server:pr-48 |
|
To run the Spring Cloud Config Server image built for this pull request: docker run --rm -d --pull=always -p 8888:8888 --name config-pr steeltoe.azurecr.io/config-server:pr-48 |
|
To run the Eureka server image built for this pull request: docker run --rm -d --pull=always -p 8761:8761 --name eureka-pr steeltoe.azurecr.io/eureka-server:pr-48 |
|
To run the Spring Boot Admin server image built for this pull request: docker run --rm -d --pull=always -p 9099:9099 --name sba-pr steeltoe.azurecr.io/spring-boot-admin:pr-48 |
I'd argue VS code is a much better option for use in this repo, and I would not expect or advise the use of VS here, but it won't hurt to add this |
bart-vmware
left a comment
bart-vmware
left a comment
There was a problem hiding this comment.
Thanks, it's all working great now.
Uh oh!
There was an error while loading. Please reload this page.