Skip to content

Fix duplicate consciousness bootstrap and import organization #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Steake merged 3 commits into from
Nov 22, 2025
Merged

Fix duplicate consciousness bootstrap and import organization #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1cc8b22
Initial plan
Copilot Nov 22, 2025
5357733
Fix duplicate bootstrap calls and move imports to top of file
Copilot Nov 22, 2025
58f622f
Add null check for phenomenal_experience in bootstrap guard
Copilot Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 17 additions & 24 deletions backend/unified_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,9 +438,20 @@ async def initialize_core_services():
# Bootstrap consciousness after initialization
if hasattr(cognitive_manager, 'consciousness_engine') and cognitive_manager.consciousness_engine:
try:
logger.info("🌅 Bootstrapping consciousness in cognitive manager...")
await cognitive_manager.consciousness_engine.bootstrap_consciousness()
logger.info("✅ Consciousness engine bootstrapped successfully")
ce = cognitive_manager.consciousness_engine
# Check if bootstrap already completed to avoid duplicate calls
bootstrap_done = False
if (hasattr(ce, 'current_state') and
hasattr(ce.current_state, 'phenomenal_experience') and
ce.current_state.phenomenal_experience):
Copy link

Copilot AI Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nested hasattr checks could fail if phenomenal_experience is not a dictionary. Consider adding a type check or restructuring the guard to be more defensive. For example, if (hasattr(ce, 'current_state') and hasattr(ce.current_state, 'phenomenal_experience') and isinstance(ce.current_state.phenomenal_experience, dict)) would prevent potential AttributeError if phenomenal_experience is None or another non-dict type.

Suggested change
ce.current_state.phenomenal_experience):
isinstance(ce.current_state.phenomenal_experience, dict)):

Copilot uses AI. Check for mistakes.
bootstrap_done = ce.current_state.phenomenal_experience.get('bootstrap_complete', False)

if not bootstrap_done:
logger.info("🌅 Bootstrapping consciousness in cognitive manager...")
await ce.bootstrap_consciousness()
logger.info("✅ Consciousness engine bootstrapped successfully")
else:
logger.info("🟡 Consciousness engine bootstrap already completed; skipping duplicate call.")
Copy link

Copilot AI Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The log message uses a semicolon where a comma or dash would be more conventional. Consider changing to "Consciousness engine bootstrap already completed, skipping duplicate call" or "Consciousness engine bootstrap already completed - skipping duplicate call" for better readability.

Suggested change
logger.info("🟡 Consciousness engine bootstrap already completed; skipping duplicate call.")
logger.info("🟡 Consciousness engine bootstrap already completed, skipping duplicate call.")

Copilot uses AI. Check for mistakes.
except Exception as bootstrap_error:
logger.warning(f"⚠️ Consciousness bootstrap warning (non-fatal): {bootstrap_error}")

Expand Down Expand Up @@ -477,27 +488,9 @@ async def initialize_core_services():
# Start the consciousness loop
await unified_consciousness_engine.start_consciousness_loop()
logger.info("🧠 Unified consciousness loop started")

# Bootstrap consciousness from unconscious state to operational awareness
logger.info("🌅 Initiating consciousness bootstrap sequence...")
try:
bootstrap_state = await unified_consciousness_engine.consciousness_state_injector.capture_current_state()
# Update unified consciousness state from bootstrap
if hasattr(bootstrap_state, 'awareness_level') and bootstrap_state.awareness_level < 0.5:
# System needs bootstrapping
logger.info("Consciousness needs bootstrap - initiating awakening sequence")
# Note: UnifiedConsciousnessEngine doesn't have bootstrap_consciousness directly
# We'll need to check if cognitive_manager has it
if cognitive_manager and hasattr(cognitive_manager, 'consciousness_engine'):
await cognitive_manager.consciousness_engine.bootstrap_consciousness()
logger.info("✅ Consciousness bootstrapped successfully via cognitive manager")
else:
logger.warning("⚠️ Cognitive manager not available for bootstrap, consciousness will self-organize")
else:
logger.info(f"Consciousness already active (level: {bootstrap_state.awareness_level:.2f})")
except Exception as bootstrap_error:
logger.warning(f"⚠️ Consciousness bootstrap encountered issue (non-fatal): {bootstrap_error}")
logger.info("Consciousness will self-organize through normal operation")

# Note: Consciousness bootstrap is handled in cognitive_manager initialization above
# to avoid duplicate bootstrap calls

except Exception as e:
logger.error(f"❌ Failed to initialize unified consciousness engine: {e}")
Expand Down
19 changes: 7 additions & 12 deletions demo_consciousness.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,13 @@
import time
from datetime import datetime

# Backend imports - moved to top for better organization
from backend.core.consciousness_engine import ConsciousnessEngine
from backend.core.unified_consciousness_engine import UnifiedConsciousnessEngine
from backend.goal_management_system import GoalManagementSystem
from backend.core.metacognitive_monitor import MetaCognitiveMonitor
from backend.core.knowledge_graph_evolution import KnowledgeGraphEvolution

# Add project to path
sys.path.insert(0, '/workspace/GodelOS')

Expand All @@ -32,8 +39,6 @@ async def demo_1_bootstrap():
print("└" + "─" * 78 + "┘")
print()

from backend.core.consciousness_engine import ConsciousnessEngine

print("Creating consciousness engine...")
engine = ConsciousnessEngine()

Expand Down Expand Up @@ -72,8 +77,6 @@ async def demo_2_real_computation():
print("└" + "─" * 78 + "┘")
print()

from backend.core.unified_consciousness_engine import UnifiedConsciousnessEngine

print("Creating unified consciousness engine...")
engine = UnifiedConsciousnessEngine()
await engine.initialize_components()
Expand Down Expand Up @@ -108,8 +111,6 @@ async def demo_3_conscious_query():
print("└" + "─" * 78 + "┘")
print()

from backend.core.unified_consciousness_engine import UnifiedConsciousnessEngine

print("Setting up consciousness engine for query processing...")
engine = UnifiedConsciousnessEngine()
await engine.initialize_components()
Expand Down Expand Up @@ -155,8 +156,6 @@ async def demo_4_goals_phenomenal():
print("└" + "─" * 78 + "┘")
print()

from backend.goal_management_system import GoalManagementSystem

print("Creating goal management system...")
goal_system = GoalManagementSystem()

Expand Down Expand Up @@ -206,8 +205,6 @@ async def demo_5_metacognition_depth():
print("└" + "─" * 78 + "┘")
print()

from backend.core.metacognitive_monitor import MetaCognitiveMonitor

print("Creating metacognitive monitor...")
monitor = MetaCognitiveMonitor()

Expand Down Expand Up @@ -248,8 +245,6 @@ async def demo_6_knowledge_graph_insights():
print("└" + "─" * 78 + "┘")
print()

from backend.core.knowledge_graph_evolution import KnowledgeGraphEvolution

print("Creating knowledge graph...")
kg = KnowledgeGraphEvolution()

Expand Down
Loading