Improve proxy management for data using COW#81
Open
pfernique wants to merge 16 commits intoStatisKit:masterfrom
Open
Improve proxy management for data using COW#81pfernique wants to merge 16 commits intoStatisKit:masterfrom
pfernique wants to merge 16 commits intoStatisKit:masterfrom
Conversation
Member
Author
|
This has to be done for:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some proxies are used to fasten data manipulation (e.g.,
WeightedData) are error prone (segfaults) or induce non user-friendly manipulation (e.g.,ProxyErrorthrown).From now, these proxies are constructed from a pointer to the decorated data and store this pointer.
Since this decorated data can be deleted, some tests are required to ensure that pointed data still exists.
Since most of these proxies are constructed from data that won't be modified, using the COW design pattern will as efficient and far more user-friendly.