Changed stamp karma to proper(ish) PageRank.#213
Open
tayler6000 wants to merge 7 commits intomasterfrom
Open
Conversation
Changed log_error and log_exception to not be async, made log_error_async and log_exception_async instead. Old names now get the event loop for you and await the async versions for you. Changed some logging messages. Added a recalculatestamps command which can be used for debugging, otherwise it's pretty much useless. Added a get_total_drains utility function to see how many drains there are in the PageRank calculation.
886779f to
a99b72b
Compare
Aprillion
approved these changes
Feb 19, 2023
Co-authored-by: Peter Hozák <peter.hozak@gmail.com>
Collaborator
Author
Yeah, I thought about it, but I did the karma first then realized I made the log error system in a stupid way when I went to implement it. |
Aprillion
approved these changes
Feb 19, 2023
Co-authored-by: Peter Hozák <peter.hozak@gmail.com>
Aprillion
approved these changes
Feb 19, 2023
Collaborator
Author
|
I think... GitHub broke my PR... |
Aprillion
approved these changes
Feb 26, 2023
Collaborator
|
Without yet putting on my math hat or opening up VSCode - I imagine a professional code reviewer might say:
|
Contributor
|
So, 2 years in, should we attempt to merge this or discard it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed log_error and log_exception to not be async, made log_error_async and log_exception_async instead. Old names now get the event loop for you and await the async versions for you. Changed some logging messages.
Added a recalculatestamps command which can be used for debugging, otherwise it's pretty much useless. Added a get_total_drains utility function to see how many drains there are in the PageRank calculation.
Waiting for Rob's review before merge.
(ish) comes from the fact that we're not supposed to do proper PageRank.