-
Notifications
You must be signed in to change notification settings - Fork 1
Update Dependencies, Migrate to Yarn, and Modernize Codebase #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Updated @babel/core from 7.26.7 to 7.28.5 - Updated @babel/eslint-parser from 7.26.5 to 7.28.5 - Updated @typescript-eslint/eslint-plugin from 5.62.0 to 8.51.0 - Updated @typescript-eslint/parser from 5.62.0 to 8.51.0 - Updated typescript from 4.9.5 to 5.9.3 - Updated eslint from 8.57.1 to 9.39.2 - Updated yargs from 15.4.1 to 18.0.0 - Updated eslint-plugin-react from 7.37.4 to 7.37.5 - Updated eslint-plugin-simple-import-sort from 10.0.0 to 12.1.1 - Updated highlight.js from 10.7.3 to 11.11.1 - Updated husky from 4.3.8 to 9.1.7 - Updated validate-npm-package-name from 3.0.0 to 7.0.1 - Fixed yargs API usage for v18 compatibility (singleton to function-based API) Co-authored-by: maximizeIT <8626039+maximizeIT@users.noreply.github.com>
|
@copilot have another look at all updates in the PR and update the PR description / title accordingly to give an overview of all code changes / version updates |
Updated the PR description with a comprehensive overview of all changes. The description now includes: Dependency Updates:
Code Changes:
Impact:
The title remains focused on the main purpose: "Update Dependencies and Modernize Codebase" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR consolidates 11 open Dependabot PRs to update dependencies across the project. The changes include major version bumps for TypeScript (4→5), ESLint (8→9), and yargs (15→18), along with numerous other dependency updates. The PR also includes an API compatibility fix for the yargs v18 migration and applies consistent code formatting throughout the codebase.
Key Changes:
- Update production dependencies (yargs, validate-npm-package-name) and dev dependencies (TypeScript, ESLint tooling, Babel, highlight.js, husky, Jest)
- Migrate yargs from singleton API to function-based API
- Apply code formatting changes (single to double quotes, spacing consistency)
Reviewed changes
Copilot reviewed 13 out of 16 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated 15+ dependencies with major and minor version bumps across production and dev dependencies |
| csss.js | Applied yargs v18 API migration, code formatting updates, and typo corrections |
| scripts/genDoc.js | Applied consistent code formatting (quotes, spacing) |
| lib/helpers.js | Minor code formatting cleanup |
| csss.test.js | Applied consistent code formatting (quotes) |
| scaffoldTpl/package.json | Updated template dependencies to latest versions (Express 5, body-parser 2, etc.) |
| scaffoldTpl/bin/www | Applied code formatting updates |
| scaffoldTpl/routes/index.js | Applied code formatting updates |
| scaffoldTpl/routes/users.js | Applied code formatting updates |
| scaffoldTpl/lib/ssoMiddleware/index.js | Applied code formatting and renamed catch variable |
| scaffoldTpl/public/stylesheets/style.css | Normalized hex color code formatting |
| scaffoldTpl/views/index.html | Removed logo image and updated README link reference |
| scaffoldTpl/README.MD | Removed logo image from header |
| README.md | Updated company name and logo image source |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@copilot apply changes based on the comments in this thread |
- Fix yargs v18 migration by adding .argv to complete the builder chain - Downgrade Jest from alpha (^30.0.0-alpha.6) to stable version (^29.7.0) - Remove body-parser dependency and use Express 5.x built-in middleware - Replace bodyParser.json() with express.json() - Replace bodyParser.urlencoded() with express.urlencoded() - Remove body-parser from scaffoldTpl/package.json Co-authored-by: maximizeIT <8626039+maximizeIT@users.noreply.github.com>
Applied all code review suggestions in commit de6f626:
All tests passing and plugin generator verified working correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 14 out of 17 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This PR consolidates all 11 open Dependabot PRs, updates dependencies to their latest versions, migrates from npm to yarn, and applies consistent code formatting across the codebase.
📦 Dependency Updates
Production Dependencies (2 updates)
yargsvalidate-npm-package-nameDevelopment Dependencies (14 updates)
Babel Ecosystem
@babel/core@babel/eslint-parserTypeScript Ecosystem
typescript@typescript-eslint/eslint-plugin@typescript-eslint/parserESLint and Plugins
eslinteslint-config-prettiereslint-plugin-reacteslint-plugin-react-hookseslint-plugin-simple-import-sortOther Dev Dependencies
highlight.jshuskyjestRemoved Dependencies
@emotion/eslint-plugin(^11.0.0) - No longer neededeslint-plugin-import-helpers(^1.1.0) - No longer neededbody-parser(from scaffoldTpl) - Now built-in to Express 5.x🔧 Code Changes
API Compatibility Fix: yargs v18
yargs v18 changed from a singleton pattern to function-based API. The builder chain now properly terminates with
.argvto parse arguments:Modified in:
csss.jsExpress 5.x Built-in Middleware
With Express 5.x, body-parser is now built-in. Removed the external body-parser dependency:
Modified in:
scaffoldTpl/app.js,scaffoldTpl/package.jsonPackage Manager Migration
package-lock.json(npm)yarn.lock(yarn)This change standardizes the project on yarn for dependency management.
Code Formatting
Applied consistent formatting across all JavaScript files:
Formatted files:
csss.js(238 lines)lib/helpers.js(24 lines)csss.test.js(13 lines)scripts/genDoc.js(34 lines)scaffoldTpl/bin/www(91 lines)scaffoldTpl/lib/ssoMiddleware/index.jsscaffoldTpl/routes/index.jsscaffoldTpl/routes/users.js✅ Testing & Validation
📊 Impact Summary
Files changed: 16
Insertions: +4,482
Deletions: -7,913
Net change: -3,431 lines (mostly from package-lock.json removal and yarn.lock addition)
yargs v18
The yargs API changed from singleton to function-based. This has been fixed in the codebase, but any external tools or scripts that directly interact with this package may need updates.
TypeScript 5.x
TypeScript was upgraded from v4 to v5. While this is generally backwards compatible, there may be minor type-checking differences.
ESLint 9.x
ESLint was upgraded to v9, which includes architectural changes. The codebase has been tested and works correctly.
Express 5.x
Express 5.x includes body-parser as built-in middleware. The body-parser package has been removed from generated applications.
🔗 Related PRs
This PR consolidates the following Dependabot PRs:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.