Skip to content

Conversation

@bjeanes
Copy link
Contributor

@bjeanes bjeanes commented Mar 9, 2013

I noticed that the ruby gem is on travis, but this is not. Ideally, it'd be great to have https://travis-ci.org/SquareSquash/web check on PR statuses. I'd like to add some tests for testing WAR building (as part of #57) so having it run in JRuby as well as MRI (and maybe Rubinius, etc) would be great.

I'm happy to add a .travis.yml file if you don't have one you already use.

@RISCfuture
Copy link
Contributor

I don't, I've never really worked with Travis and sort of accepted on blind faith a .travis.yml file given to me for the gem :)

@bjeanes
Copy link
Contributor Author

bjeanes commented Mar 7, 2013

Would you be open to setting up travis for this project too? I'll add the configs if so.

@RISCfuture
Copy link
Contributor

Sure!

@bjeanes
Copy link
Contributor Author

bjeanes commented Mar 9, 2013

OK... I've attached some code that adds a Travis config file.

The build doesn't pass yet because the tests don't pass without having run setup.rb which is not headless (tracked in #62).

Furthermore, the JRuby build is failing because it can't migrate without raising an exception. This seems to be a problem with activerecord-jdbc-adapter v1.2.5. The comment in the Gemfile implies that v1.2.6 is broken.

@RISCfuture, do you know if the problem is also in v1.2.7? If so, v1.2.2 works, but I'm not sure if this causes other problems for you.

@bjeanes
Copy link
Contributor Author

bjeanes commented Mar 9, 2013

Ah, according to jruby/activerecord-jdbc-adapter#322 and the README, v1.2.7 should address the concern which is alluded to in the Gemfile. I don't yet know if it fixes the rake db:schema:dump issue I'm seeing, but I'll give it a try.

@bjeanes bjeanes closed this Jun 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants