This repository was archived by the owner on Jul 10, 2022. It is now read-only.
Feature/4 #7
Open
Feature/4 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding service class for Address TODO common Abstract Class
Cart checkout order customer
2)Fixing naming bug.
Contributor
Author
|
@duergner For merging |
| public class Delivery extends Base { | ||
|
|
||
| @JsonProperty | ||
| private String earliest; |
Member
There was a problem hiding this comment.
We should maybe use Date here instead of String and apply correct @JsonFormat
class. Adding token property on Payment Some Camel case fixes
|
|
||
| public Address(){} | ||
|
|
||
| public Address(String id, String customer_number, String gender, String first_name, String last_name, String street,String additional, String zip, String city, String country_code, Boolean pack_station,Boolean default_billing, Boolean default_shipping) { |
Member
There was a problem hiding this comment.
Use camel case for parameters please
(ü) when posting data Adding "problem" class to get details of the exceptions Changing the api path for adding updating cart Passing accessToken to get customer details Adding clientId and clientCredentials in abstractservice
1) Changed magic numbers to HttpHeaders 2)Added authorization on checkout and order services
Contributor
Author
|
@duergner Please recheck .Thanks! |
| request.setHeader(HttpHeaders.CONTENT_TYPE,"application/x-www-form-urlencoded"); | ||
|
|
||
| List<NameValuePair> params = new ArrayList<NameValuePair>(); | ||
| params.add(new BasicNameValuePair("realm","%2Fcustomers")); |
Member
There was a problem hiding this comment.
You can use / here; it will be correctly encoded on the entity
and adding /customers instead of encoded value
Contributor
Author
|
@duergner One more time review plz :) |
Member
|
Looks fine - I'll merge it in later |
- Changing app_domain_id to sales channel. - Linking corrrect property to shipping address id in checkout object - Updating the api url for checkout and order
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.