This repository was archived by the owner on Jul 10, 2022. It is now read-only.
Feature/4 #6
Open
Feature/4 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding service class for Address TODO common Abstract Class
Cart checkout order customer
| public abstract class Address extends Base { | ||
|
|
||
| @JsonProperty | ||
| private String id; |
Member
There was a problem hiding this comment.
Please use empty lines between the single properties
(ü) when posting data Adding "problem" class to get details of the exceptions Changing the api path for adding updating cart Passing accessToken to get customer details Adding clientId and clientCredentials in abstractservice
Contributor
Author
|
@duergner For your review. Changes done while integration with staging zalando APis |
|
|
||
| @Override | ||
| public TokenInfo read() throws Exception { | ||
| HttpPost request = postRequest("/access_token?realm=%2Fcustomers&grant_type=client_credentials&client_id="+clientId+"&client_secret="+clientCredential); |
Member
There was a problem hiding this comment.
Please use NameValuePair to create the correct body / request parameters instead of doing String concatenation
1) Changed magic numbers to HttpHeaders 2)Added authorization on checkout and order services
and adding /customers instead of encoded value
- Changing app_domain_id to sales channel. - Linking corrrect property to shipping address id in checkout object - Updating the api url for checkout and order
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@duergner For your review
Ref : Issue #4
1)Added Address Response/Request objects for create/get/update
2)Address AddressService to fetch/create/update address in zalando
3)Added Abstract Service same as already existing (Might need some changes here)
PS : Will not merge it with master.