Skip to content

Fix URL Caching and Optimize Cache Refreshing #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohammadaminmg10 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix URL Caching and Optimize Cache Refreshing #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
package cache

/*
MIT License

Expand All @@ -22,8 +24,6 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
*/

package cache

import (
"bufio"
"bytes"
Expand Down Expand Up @@ -116,6 +116,7 @@ type Adapter interface {
func (client *Client) Middleware() echo.MiddlewareFunc {
return func(next echo.HandlerFunc) echo.HandlerFunc {
return func(c echo.Context) error {
c.Request().URL.ForceQuery = false
if !client.isAllowedPathToCache(c.Request().URL.String()) {
next(c)
return nil
Expand All @@ -142,7 +143,6 @@ func (client *Client) Middleware() echo.MiddlewareFunc {
c.Request().URL.RawQuery = params.Encode()
key = generateKey(c.Request().URL.String())

client.adapter.Release(key)
} else {
b, ok := client.adapter.Get(key)
response := BytesToResponse(b)
Expand All @@ -160,8 +160,6 @@ func (client *Client) Middleware() echo.MiddlewareFunc {
c.Response().Write(response.Value)
return nil
}

client.adapter.Release(key)
}
}

Expand All @@ -185,6 +183,7 @@ func (client *Client) Middleware() echo.MiddlewareFunc {
LastAccess: now,
Frequency: 1,
}
client.adapter.Release(key)
client.adapter.Set(key, response.Bytes(), response.Expiration)
}
//for k, v := range writer.Header() {
Expand Down