feat: startup automations and enhancements#190
Conversation
…tup automations, and ensure Windows binaries ship with optimized JVM args
SpoilerRules
changed the title
|
@codex code review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b177310994
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ui/src/main/kotlin/com/spoiligaming/explorer/ui/systemtray/AppSystemTray.kt
Outdated
Show resolved
Hide resolved
ui/src/main/kotlin/com/spoiligaming/explorer/ui/screens/setup/SetupScreen.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 860ac277af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| selectedLocale = state.locale, | ||
| onLocaleSelected = { locale -> | ||
| preferenceSettingsManager.updateSettings { | ||
| it.copy(locale = locale) | ||
| } | ||
| state.locale = locale | ||
| }, |
There was a problem hiding this comment.
This handler now only stores the language in state.locale, but the app’s translations still come from LocalPrefs.current.locale in AppLocaleProvider, and that preference is only persisted during persistSetupState() on Finish. In practice, changing language in step 1 no longer re-localizes the remaining setup steps, so users who switch language to understand onboarding still see the old locale until the wizard exits.
Useful? React with 👍 / 👎.
| remember(isAutoStartupLaunch, startupSettings.shouldStartMinimizedToSystemTray) { | ||
| mutableStateOf( | ||
| !(isAutoStartupLaunch && startupSettings.shouldStartMinimizedToSystemTray), | ||
| ) |
There was a problem hiding this comment.
Because isWindowVisible is remembered with startupSettings.shouldStartMinimizedToSystemTray as a key, changing the startup behavior at runtime recreates this state from the initial auto-start formula. In an auto-started session, toggling "start minimized" can immediately hide/show the current window even though this preference should only affect future launches.
Useful? React with 👍 / 👎.
1 participant
No description provided.