Replace delayMicroseconds by _delay_us #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I think this may want to be fixed in the core itself.... ie, have delayMicroseconds, as long as it's passed a constant, use _delay_us() instead of our implementation, Quite frankly, I don't know why don't do that in general. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, little fix for my project, maybe there are better ways to fix it.
I was working with ATtiny1614 (at 1MHz) when my DS18B20 was not responding with this library. I tried 4 and 8 MHz with success but 1MHz is too low for current implementation.
After investigating, the overhead of delayMicroseconds seems to be the cause. I replaced it with _delay_us from AVR libraries and it works like a charm.