Changes to Navbar #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
December 13, 2022 19:48
…link to current page is clicked
…ms & removed duplicated footer
✅ Deploy Preview for sparkledge ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
added 2 commits
December 21, 2022 17:33
SKupisz
requested changes
Jan 5, 2023
Contributor
SKupisz
left a comment
SKupisz
left a comment
There was a problem hiding this comment.
- styled/subcomponents/navbar.tsx:
- generally:
a) min-width instead of max-width
b) we use only vh when it comes to the height of components
c) try to avoid "the divology" - it's not bad, but could be better - NavbarItem > hover without additional colour, let's leave filter brightness there
- NavbarItemWrapper > RWD stuff goes at the end of a component
- NavbarProps > put it on the top of the file
- NavbarContainer > z-index should be constant and unchangeable
-
Welcome component
Something goes wrong with the filter after the changes > visible in the light mode -
Navbar in components/subcomponents/navbar.tsx
- Opening and closing could be perhaps better with the usage of framer-motion
- extract rendering of the specific groups of elements to separate files or make it as an array and then map it > the component is pretty long and the maintainability could be a bit harsh
- More icons, less text in the navbar's items
- state variables > missing the type of the variable after the useState and after useLocalStorage
Apart from that, everything looks good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.