Fix link to Loading Conversations notebook #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonidb
force-pushed
the
fix-link-to-Loading-Conversation-notebook
branch
from
d6565cd to
ab1a309
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a broken link in the README.md file that was referencing a non-existent notebook file, addressing issue #95. The change updates the link from load_conversations_from_csv.ipynb to the correct filename loading_conversations.ipynb.
- Updates README documentation to fix broken notebook link
- Standardizes Discord badge styling across README files
- Updates notebook execution timestamps and output data from re-running examples
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| agentune_simulate/README.md | Fixes broken link to loading conversations notebook and updates Discord badge |
| README.md | Updates Discord badge styling for consistency |
| agentune_simulate/examples/persistent_storage_example.ipynb | Updates execution timestamps and output from re-running the notebook |
| agentune_simulate/agentune/simulate/models/results.py | Adds support for displaying conversations without outcomes in summary |
ErikLagerSB
approved these changes
Jul 23, 2025
| "output_file = \"chroma_simulation_results.json\"\n", | ||
| "chroma_result.save_to_file(output_file)\n", | ||
| "print(f\"\\n✓ Results saved to {Path(output_file).absolute()}\")" | ||
| "print(f\"\\n✓ Results saved to {Path(output_file).resolve().relative_to(Path('../../').resolve())}\")" |
Contributor
There was a problem hiding this comment.
This is to anonymize the path?
Collaborator
Author
There was a problem hiding this comment.
To remove the part specific to the machine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes #95