-
Notifications
You must be signed in to change notification settings - Fork 18
Fix pipline and some CI improvments #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Lauriichan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all thanks for your PR!
We appreciate your work on this even though I kinda feel like the Github CI pipeline isn't really something that is necessary for SmoothTimber.
As mentioned in the comments there are a couple things I don't want to merge right now if we can resolve them I see no issues with this PR otherwise.
|
Also if you feel like wanting to help on SmoothTimber check out the current branch which contains a rework for SmoothTimber which still requires work before it can be released :) |
i saw the current branch but after there was no new commit here for 3 years I thought it was not so current. |
|
Yeah sadly nobody has been working on it for quite a bit, I don't think I do have any changes locally on it cause I was mainly working on JumpLeaguePlus and RWG when it comes to SourceWriters recently but yeah. |
my motivation is currently only to fix github actions i dont like failing actions and since I have already played around with it a lot, I am happy to make PRs for it that might be helpful |
|
Quick explanation for the current branch: Generally the current branch is technically a working plugin however it is not yet SmoothTimber if that makes sense. EDIT: In addition to that is the addon support which allows to expand using the same api the core uses which means it can add support for more trees, new animations and even new block groups. Basically all tools are available to them to do anything we can do in the core, allowing for any developer to add whatever they want into the plugin without needing to make a PR but can just make a jar and put that into the addons folder. |
I see, thank you for your work either way :) |
|
I will approve and merge this tmr or sometime this weekend |
Lauriichan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is fine now, merge will occur soon.
Thank you! :)

pin all workflows to the SHA Commit to improve Workflow Security (It is recommended to use pinned versions for Github Actions and dont use e.g. master as version)
So you can then also think about activating this:
https://github.blog/changelog/2025-08-15-github-actions-policy-now-supports-blocking-and-sha-pinning-actions
add dependabot for Github Actions to updates also works for SHA Pinned Versions
see test PR Bump actions/setup-java from 4.7.1 to 5.0.0 T0biii/SmoothTimber#6
the interval for the dependabot can be set also to
daily, weekly, monthly, quarterly, semiannually or yearly
so you dont get spam mails :)
I deleted one of the workflow files because both were almost doing the same thing, and the remaining one was extended to only upload the build when pushed to legacy.
PR:

legacy branch:
is there a reasone why to skip the upload part for PRs?