Skip to content

Conversation

@T0biii
Copy link
Contributor

@T0biii T0biii commented Sep 25, 2025

  • Fixing Path for Artifact
image
  • Bump all CI Version
image

PR:
image

legacy branch:

image

is there a reasone why to skip the upload part for PRs?

Copy link
Member

@Lauriichan Lauriichan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all thanks for your PR!

We appreciate your work on this even though I kinda feel like the Github CI pipeline isn't really something that is necessary for SmoothTimber.

As mentioned in the comments there are a couple things I don't want to merge right now if we can resolve them I see no issues with this PR otherwise.

@Lauriichan
Copy link
Member

Also if you feel like wanting to help on SmoothTimber check out the current branch which contains a rework for SmoothTimber which still requires work before it can be released :)

@T0biii
Copy link
Contributor Author

T0biii commented Sep 25, 2025

Also if you feel like wanting to help on SmoothTimber check out the current branch which contains a rework for SmoothTimber which still requires work before it can be released :)

i saw the current branch but after there was no new commit here for 3 years I thought it was not so current.
and since the legacy branch is the default branch, I didn't look into it any further

@Lauriichan
Copy link
Member

Lauriichan commented Sep 25, 2025

Yeah sadly nobody has been working on it for quite a bit, I don't think I do have any changes locally on it cause I was mainly working on JumpLeaguePlus and RWG when it comes to SourceWriters recently but yeah.
The project was originally planned to be continued by another team member but they haven't worked on it so it kind of just yeah existed x)

@T0biii
Copy link
Contributor Author

T0biii commented Sep 25, 2025

Yeah sadly nobody has been working on it for quite a bit, I don't think I do have any changes locally on it cause I was mainly working on JumpLeaguePlus and RWG when it comes to SourceWriters recently but yeah. The project was originally planned to be continued by another team member but they haven't worked on it so it kind of just yeah existed x)

my motivation is currently only to fix github actions i dont like failing actions and since I have already played around with it a lot, I am happy to make PRs for it that might be helpful

@Lauriichan
Copy link
Member

Lauriichan commented Sep 25, 2025

Quick explanation for the current branch:

Generally the current branch is technically a working plugin however it is not yet SmoothTimber if that makes sense.
How it works is that there is an api layer for addons/the core which is supposed to allow the plugin to work on multiple platforms at a possible later date and time.
I think I've done a good job decoupling everything and the approach to how trees are detected and cut is also completely different.
I think the core components are there but the things missing are animations and tree detectors.
Other than the legacy SmoothTimber the new one doesn't just check for wood blocks instead it defines block groups (can theoretically support modded blocks) which are then checked for in the tree detectors using a detection cache and yeah the detector itself which is supposed to detect a tree shape.

EDIT: In addition to that is the addon support which allows to expand using the same api the core uses which means it can add support for more trees, new animations and even new block groups. Basically all tools are available to them to do anything we can do in the core, allowing for any developer to add whatever they want into the plugin without needing to make a PR but can just make a jar and put that into the addons folder.
This is somewhat similar to what PlaceholderAPI does with their addons.

@Lauriichan
Copy link
Member

Yeah sadly nobody has been working on it for quite a bit, I don't think I do have any changes locally on it cause I was mainly working on JumpLeaguePlus and RWG when it comes to SourceWriters recently but yeah. The project was originally planned to be continued by another team member but they haven't worked on it so it kind of just yeah existed x)

my motivation is currently only to fix github actions i dont like failing actions and since I have already played around with it a lot, I am happy to make PRs for it that might be helpful

I see, thank you for your work either way :)

@Lauriichan
Copy link
Member

I will approve and merge this tmr or sometime this weekend

Copy link
Member

@Lauriichan Lauriichan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is fine now, merge will occur soon.
Thank you! :)

@T0biii
Copy link
Contributor Author

T0biii commented Sep 25, 2025

just tested again, sorry pull_request is also need push only worked because the branch was in the same repo

but now after adding it runs:
image

@Lauriichan Lauriichan merged commit a544bc1 into SourceWriters:legacy Sep 26, 2025
2 checks passed
@T0biii T0biii deleted the fix-pipline branch September 26, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants