Skip to content

engine: reduce CBaseClient size & move scratch buffer #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RaphaelIT7 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

engine: reduce CBaseClient size & move scratch buffer #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7eaaf4
engine: reduce CBaseClient size & move scratch buffer
RaphaelIT7 Nov 17, 2025
c74fde1
engine: fix me using the wrong size for the scratch buffer
RaphaelIT7 Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion engine/baseclient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
#include "iregistry.h"
#include "sv_main.h"
#include "hltvserver.h"
#include <memory>

#ifdef REPLAY_ENABLED
#include "replay_internal.h"
Expand Down Expand Up @@ -1153,7 +1154,9 @@ void CBaseClient::SendSnapshot( CClientFrame *pFrame )

bool bFailedOnce = false;
write_again:
bf_write msg( "CBaseClient::SendSnapshot", m_SnapshotScratchBuffer, sizeof( m_SnapshotScratchBuffer ) );
// RaphaelIT7: Were deep in networking and the stack can easily get close to an overflow
static thread_local std::unique_ptr<unsigned int> pSnapshotScratchBuffer(new unsigned int[g_nScratchBufferSizeAsInt]);
bf_write msg( "CBaseClient::SendSnapshot", pSnapshotScratchBuffer.get(), SNAPSHOT_SCRATCH_BUFFER_SIZE );

TRACE_PACKET( ( "SendSnapshot(%d)\n", pFrame->tick_count ) );

Expand Down
3 changes: 1 addition & 2 deletions engine/baseclient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,8 +276,7 @@ class CBaseClient : public IGameEventListener2, public IClient, public IClientMe
{
SNAPSHOT_SCRATCH_BUFFER_SIZE = 160000,
};

unsigned int m_SnapshotScratchBuffer[ SNAPSHOT_SCRATCH_BUFFER_SIZE / 4 ];
static constexpr int g_nScratchBufferSizeAsInt = SNAPSHOT_SCRATCH_BUFFER_SIZE / sizeof(unsigned int);

private:
void StartTrace( bf_write &msg );
Expand Down