Backport --predict-overwrite from upstream #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may be useful for users who find prediction's activity right of the cursor distracting. Prediction underscoring is still a little weird sometimes, it replays a history of known/unknown changes as acks come in from the server.
ammgws
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The official mosh client added support for the option “--predict-overwrite” in 2017, which greatly enhances the user experience when the remote is using
fishas its shell. Without this mosh can be almost unusable, forcing one to use SSH instead (See mobile-shell/mosh#932).From the description of this repo ("Android compatible mosh-client based on Dan Drown's repo"), it seems like this may be the mosh client used by JuiceSSH. In that case this PR should hopefully allow for a future option in JuiceSSH for the user to turn on "--predict-overwrite". As a paid user I feel like that is the feature missing from JuiceSSH (though to be honest I do not know of any alternatives).
Commits cherry-picked from upstream:
mobile-shell/mosh@8aac3cc
mobile-shell/mosh@c8580d1