Skip to content

copycat with Catsite#1

Open
Ken1414 wants to merge 4 commits intoSoloSteve:mainfrom
Ken1414:pulldev
Open

copycat with Catsite#1
Ken1414 wants to merge 4 commits intoSoloSteve:mainfrom
Ken1414:pulldev

Conversation

@Ken1414
Copy link

@Ken1414 Ken1414 commented Jun 21, 2024

@SoloSteve
I have made changes to ensure the application runs on the web. To run the web application locally, please follow these steps:

1 : Open the terminal and navigate to the project directory.

2 : Run the following command:
python3 manage.py runserver

3 : Open your browser and go to http://localhost:8000 to use the web application.

⚠️This pull request is based on my repository "Catsite1.1", so I have removed the original "copycat" files during the changes. However, please rest assured that the same data is now stored in the added "Catsite1.1_pullreq" files.
If these changes are merged, they will overwrite everything. Therefore, if you plan to use them, I recommend first checking the data from my repository.

My English may be clumsy, but please take a moment to read through it.
It took a while, but I'll provide the current code. I hope it will inspire some new ideas 🙏

@SoloSteve
Copy link
Owner

SoloSteve commented Jun 23, 2024

Hey @Ken1414. Thank you very much for opening the pull request, I was eagerly waiting for it 🙂.

I would love to review it and merge but due to the way you created the pull requests it's very hard to see the diff.

What is the reason you chose to add a submodule as opposed to copy-pasting the files?
I think you should be able to simply copy-paste your code into your branch (overwriting the old files), and open the PR that way.

I do trust you that it's the same data, the main reason I'd like you to create the PR a different way is so I can easily view the changes, and comment on potential mistakes or improvements to the code before merging.

What do you think?

@Ken1414
Copy link
Author

Ken1414 commented Jun 24, 2024

Hello @SoloSteve!

Thank you for your feedback. I understand the problem. I appreciate your suggestion.😌👌

I'm new to GitHub, so I mistakenly thought that adding a submodule would make it easy to see the diff. Thanks for letting me know. I'll try to make the change.

However, I'm still learning, so it may take some time to make these changes. Thank you for your understanding and cooperation.🙏

Thank you for your cooperation.

@SoloSteve
Copy link
Owner

No problem @Ken1414. Take your time.

Let me know if you need any help :)

@Ken1414 Ken1414 closed this Jul 11, 2024
@Ken1414 Ken1414 deleted the pulldev branch July 11, 2024 04:16
@Ken1414 Ken1414 restored the pulldev branch July 11, 2024 04:41
@Ken1414 Ken1414 reopened this Jul 20, 2024
@Ken1414
Copy link
Author

Ken1414 commented Jul 20, 2024

@SoloSteve
Thank you for your patience! 🥲

Can you please check if this works now.

Since this is an adaptation of the web application, we haven't made many changes to the original copycat program. Please disregard any major changes within copycat that were removed and added back during the process.

Additionally, while creating the pull request, we started a new program from scratch, but we are currently fixing a bug where form submissions on the web are not functioning correctly 🤧
Other than that, I believe all the differences have been applied, so please review it.

I will commit again once the fixes are complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants