Rebased Feature: Implement keypoint filtering with cv::Mat#65
Open
Rebased Feature: Implement keypoint filtering with cv::Mat#65
Conversation
move mask out to top level System call
4 tasks
Owner
Author
|
Did some testing and this works fine in RGBD but causes segmentation faults in Stereo. Cannot find the cause as of now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #46
Description & Motivation
Fixes #9
We are adding orb-filtering from a cv::Mat mask to allow for future refinements such as filtering moving objects out of the SLAM algorithm.
What is the issue is addressed? Please also include relevant motivation and context.
Changes made
Type of Change
Changes
This adds a mask argument to the Frame, Tracking, and System classes. It also creates an override in ORBExtractor for both masked and non-masked versions of a frame.
To specify no mask, pass nullptr as the mask argument instead of the address of a cv::Mat.
THIS IS BREAKING: old examples will not run without adding the mask argument (can use nullptr).
Test Plan
Ran a local test on the Jetson Orin and verified ORBS were not obtained outside of the mask.
Test Configuration:
Will need to do a second test to verify integrity of the SLAM algorithm
Test Configuration: