feat: allow returning error from adlib actions in blueprints#1638
Draft
anteeek wants to merge 1 commit intoSofie-Automation:mainfrom
Draft
feat: allow returning error from adlib actions in blueprints#1638anteeek wants to merge 1 commit intoSofie-Automation:mainfrom
anteeek wants to merge 1 commit intoSofie-Automation:mainfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
b2484b1 to
545404c
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the Contributor
This PR is made on behalf of the BBC
Type of Contribution
This is a:
Feature
Current Behavior
Currently, there's no way to return a meaningful error message (other than just 500 - failed) from running an adlib action
New Behavior
This PR adds a method that allows to return a meaningful error message as to why an action has failed due to user error (it's meant for expected errors, exceptions are still a valid exit point for method and still will be handled as-is)
Testing
Affected areas
Blueprints integration
Time Frame
Other Information
Status