Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Caution Review failedThe pull request is closed. WalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I believe we explicitly do not build this all the time because building the openapi client requires java, and due to licensing reasons some devs have been reluctant to install and use that |
|
Problem is this fails without it: https://github.com/Sofie-Automation/sofie-core/actions/runs/21671643804 |
|
I would be tempted to change to something like:The general build workflow is doing that already https://github.com/Sofie-Automation/sofie-core/blob/92b183b201041bdb1197b3763b421e1a84c4bf1e/.github/workflows/node.yaml#L515C9-L519 |
|
Yeah, seems reasonable, have updated |
|
I didnt really like having to do these special cases for openapi, instead I want to propose rebuilding the package with a different generator so that we can remove the reliance on java entirely. |
|



About the Contributor
This pull request is posted on behalf of the TSC.
Type of Contribution
This is a: Bug fix
Current Behavior
OpenAPI build fails
New Behavior
OpenAPI build completes
Testing
Affected areas
This PR affects CI
Time Frame
This bug fix needs to be merged into 26.03
Other Information
Status
Changes to
.github/workflows/publish-libs.ymlThe
test-packagesworkflow job's build step has been updated to conditionally build the OpenAPI package differently from other packages:yarn workspace @sofie-automation/openapi run buildyarn build:single ${{ matrix.package-name }}/tsconfig.build.jsonThis conditional logic (lines 123–127) ensures the OpenAPI client is built in the test-packages job, which uses Java-dependent tooling required for OpenAPI generation. The workflow file uses tabs for indentation throughout.
The change resolves a CI failure where the OpenAPI build was not completing, while maintaining the existing build process for other packages (blueprints-integration, server-core-integration, shared-lib) that do not require Java.