Conversation
split is still needed for jest though, so this is a alter task
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Julusian
added
the
Contribution from SuperFly.tv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of Superfly
Type of Contribution
This is a: Code improvement
This continues on from #1597
New Behavior
Instead of having separate eslint configurations for each package, and invoking them separately, this converts the config into a single combined config.
This has the benefit of presenting all the linter issues at once instead of the lint running stopping at the first package with a failure.
It is still possible to lint just a single package at a time, they have retained a script which will do exactly that.
Additionally, this extends the tsconfig so that the
yarn watchcommand inside the packages folder will type check unit tests. Due to our split tsconfig structure, this has been missing for a while.This is achieved by adding a new tsconfig which runs for all test files.
As a follow up, I intend to merge the tsconfig.build.json and tsconfig.json files, in each package, but to do that requires reconfiguring jest (or swapping jest for vitest).
The CI workflows have been adjusted to invoke the linter once for all the packages, instead of running each package individually. I do not know if this is best or if we prefer it as multiple jobs, but I expect this to be faster overall and reduces the very long list of jobs we currently have
Testing
Affected areas
Time Frame
Other Information
Status