fix: duration of pieces with 'now' start time#1628
fix: duration of pieces with 'now' start time#1628ianshade wants to merge 1 commit intoSofie-Automation:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Tip 🧪 Unit Test Generation v2 is now available!We have significantly improved our unit test generation capabilities. To enable: Add this to your reviews:
finishing_touches:
unit_tests:
enabled: trueTry it out by using the Have feedback? Share your thoughts on our Discord thread! Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
60c5689 to
1fc46cc
Compare
1fc46cc to
535c288
Compare
About the Contributor
This pull request is posted on behalf of TV 2 Norge
Type of Contribution
This is a:
Bug fix
Current Behavior
Certain pieces with
durationspecified might not end when expected due to lostdurationon the control timeline object. I believe this is a reintroduction of a bug that was fixed in #1416 into new code pathsNew Behavior
Properties other than
startare preserved when denowifyingTesting
Affected areas
Playout of dynamically inserted pieces in multi-gateway mode
Time Frame
Other Information
Status