Skip to content

feat: allow blueprints to specify preview and thumbnail containter ids in applyConfig#1613

Open
ianshade wants to merge 1 commit intoSofie-Automation:mainfrom
tv2norge-collab:contribute/EAV-663
Open

feat: allow blueprints to specify preview and thumbnail containter ids in applyConfig#1613
ianshade wants to merge 1 commit intoSofie-Automation:mainfrom
tv2norge-collab:contribute/EAV-663

Conversation

@ianshade
Copy link
Contributor

About the Contributor

This pull request is posted on behalf of TV 2 Norge.

Type of Contribution

This is a: Feature

Current Behavior

Previously, blueprints did not have the ability to specify custom preview and thumbnail container IDs in the applyConfig method. Container IDs had to be configured manually by the user.

New Behavior

Blueprints can now specify custom preview and thumbnail container IDs directly in the applyConfig method.
Additionally a new, cleaner way of defining migrations as classes is introduced.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

  • This PR affects blueprint configuration and preview/thumbnail container handling
  • Changes apply to the applyConfig method in blueprint integration
  • Migrations

Time Frame

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author. (before porting to release53)
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@ianshade ianshade requested a review from a team as a code owner January 23, 2026 12:56
@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ianshade ianshade added the Contribution from TV 2 Norge Contributions sponsored by TV 2 Norge (tv2.no) label Jan 23, 2026
@codecov
Copy link

codecov bot commented Jan 23, 2026

/** Package Containers */
packageContainers?: Record<string, StudioPackageContainer>
/** Which Package Containers are used for media previews/thumbnails in GUI */
packageContainerIds?: StudioPackageContainerIds
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps this should be called packageContainerSettings?

Expands the scope to allow more package container related things to be put in here too if they are needed in the future.

I dont mind though

}
export interface PieceContentStatusStudio
extends Pick<DBStudio, '_id' | 'previewContainerIds' | 'thumbnailContainerIds'> {
export interface PieceContentStatusStudio extends Pick<DBStudio, '_id'> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, the Pick<DBStudio feels rather silly. Perhaps time to drop that and define _id explicitly

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to have this in a folder matching the X_X_X naming scheme, so that we can more easily keep track of which steps are being for each version. (Which will help us when we want to clean migrations from some really old versions again)

I like the class approach though, seems like it will help with some of the duplication 'problem' that bugs me with the other approach (not enough to consider changing it though)

@PeterC89 PeterC89 changed the base branch from release53 to main February 4, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Contribution from TV 2 Norge Contributions sponsored by TV 2 Norge (tv2.no)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants