feat: allow blueprints to specify preview and thumbnail containter ids in applyConfig#1613
feat: allow blueprints to specify preview and thumbnail containter ids in applyConfig#1613ianshade wants to merge 1 commit intoSofie-Automation:mainfrom
applyConfig#1613Conversation
…ainter ids in `applyConfig`
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
| /** Package Containers */ | ||
| packageContainers?: Record<string, StudioPackageContainer> | ||
| /** Which Package Containers are used for media previews/thumbnails in GUI */ | ||
| packageContainerIds?: StudioPackageContainerIds |
There was a problem hiding this comment.
perhaps this should be called packageContainerSettings?
Expands the scope to allow more package container related things to be put in here too if they are needed in the future.
I dont mind though
| } | ||
| export interface PieceContentStatusStudio | ||
| extends Pick<DBStudio, '_id' | 'previewContainerIds' | 'thumbnailContainerIds'> { | ||
| export interface PieceContentStatusStudio extends Pick<DBStudio, '_id'> { |
There was a problem hiding this comment.
At this point, the Pick<DBStudio feels rather silly. Perhaps time to drop that and define _id explicitly
There was a problem hiding this comment.
I think it would be good to have this in a folder matching the X_X_X naming scheme, so that we can more easily keep track of which steps are being for each version. (Which will help us when we want to clean migrations from some really old versions again)
I like the class approach though, seems like it will help with some of the duplication 'problem' that bugs me with the other approach (not enough to consider changing it though)
About the Contributor
This pull request is posted on behalf of TV 2 Norge.
Type of Contribution
This is a: Feature
Current Behavior
Previously, blueprints did not have the ability to specify custom preview and thumbnail container IDs in the
applyConfigmethod. Container IDs had to be configured manually by the user.New Behavior
Blueprints can now specify custom preview and thumbnail container IDs directly in the
applyConfigmethod.Additionally a new, cleaner way of defining migrations as classes is introduced.
Testing
Affected areas
applyConfigmethod in blueprint integrationTime Frame
Other Information
Status