Skip to content

Add support for numbers #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
v-volod merged 1 commit into from
Dec 18, 2025
Merged

Add support for numbers #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Sources/SnappThemingDesignTokensSupport/Convertor/DesignTokensConverter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,9 @@ public struct DesignTokensConverter: Sendable {
return .typography(fontWeightMapping: configuration.fontWeightMapping)
case .gradient:
return .gradient(using: configuration.colorHexFormat)
case .fontWeight, .number,
case .number:
return .number
case .fontWeight,
.duration, .shadow, .strokeStyle, .border,
.cubicBezier, .transition:
fallthrough
Expand Down
15 changes: 15 additions & 0 deletions ...nappThemingDesignTokensSupport/Convertor/Extractor/DesignTokensNumberValueExtractor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
//
// DesignTokensNumberValueExtractor.swift
//
// Created by Volodymyr Voiko on 09.04.2025.
//

import Foundation
import SnappDesignTokens
import SnappTheming

extension DesignTokensTokenValueExtractor {
static var number: Self {
Copy link
Collaborator

@oleksiikolomiietssnapp oleksiikolomiietssnapp Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public?

Copy link
Collaborator Author

@v-volod v-volod Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, extractors are used internally.

.init(\.metricsCache) { $0 }
}
}
8 changes: 8 additions & 0 deletions Tests/SnappThemingDesignTokensSupportTests/Resources/design.tokens.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,14 @@
}
]
}
},
"number": {
"aspect": {
"square": {
"$type": "number",
"$value": 1.0
}
}
}
},
"files": {
Expand Down
1 change: 1 addition & 0 deletions Tests/SnappThemingDesignTokensSupportTests/Resources/expected.snapptheming.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
"baseDimensionSpacing20" : 20,
"semanticFontsizeBody" : 16,
"semanticFontsizeH1" : 32,
"semanticNumberAspectSquare" : 1,
"semanticSpacingMedium" : 20,
"semanticSpacingSmall" : 10
},
Expand Down
6 changes: 3 additions & 3 deletions Tests/SnappThemingDesignTokensSupportTests/SnappThemingDesignTokensParserTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,13 @@ struct SnappThemingDesignTokensParserTests {
#"""
{
"unsupported": {
"$type": "number",
"$value": 0.5
"$type": "fontWeight",
"$value": 100
}
}
"""#,
DesignTokensConverter.Error.unsupportedToken(
.value(.number(0.5)),
.value(.fontWeight(FontWeightValue(alias: .thin))),
forKey: "unsupported"
)
),
Expand Down