Remove Potential TOCTOU Issue in basing.py #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* keripy/src/keri/db/basing.py - Remove a potential TOCTOU issue in the `Baser.clean()` method when using `shutil` functions. Now instead of `if (exists)`, use `unlinkat(2)`-style deletions by opening the parent directory and unconditionally running the deletions - Additionally pre-compute the value of `/usr/local/var/keri/clean` so there's no reliance on the runtime or using something like `python3 -m compileall -OO` to hoist this value before passing it into `shutil.rmtree()` These may not be serious issues depending on the environment, but these changes should reduce the chances of malicious or misbehaving code to cause problems.
Corrected the use of `dirname()`/`basename()` functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Baser.clean()method when usingshutilfunctions. Now instead ofif (exists), useunlinkat(2)-style deletions by opening the parent directory and unconditionally running the deletions/usr/local/var/keri/cleanso there's no reliance on the runtime or using something likepython3 -m compileall -OOto hoist this value before passing it intoshutil.rmtree()These may not be serious issues depending on the environment, but these changes should reduce the chances of malicious or misbehaving code to cause problems.