Fix FFmpeg guidance and changelog clarity for HEIC/HEIF/GIF/MOV support#172
Merged
Fix FFmpeg guidance and changelog clarity for HEIC/HEIF/GIF/MOV support#172
Conversation
Co-authored-by: SmilyOrg <1451391+SmilyOrg@users.noreply.github.com>
Co-authored-by: SmilyOrg <1451391+SmilyOrg@users.noreply.github.com>
Co-authored-by: SmilyOrg <1451391+SmilyOrg@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for HEIC, GIF, and MOV formats with FFmpeg integration
Fix MIME registration, FFmpeg guidance, and changelog clarity for HEIC/HEIF/GIF/MOV support
Jan 26, 2026
SmilyOrg
requested changes
Jan 26, 2026
Comment on lines
2292
to
2294
| mime.AddExtensionType(".png", "image/png") | ||
| mime.AddExtensionType(".jpg", "image/jpg") | ||
| mime.AddExtensionType(".jpeg", "image/jpeg") |
Owner
There was a problem hiding this comment.
Actually, let's keep these as they can appear in UI assets
Contributor
Author
There was a problem hiding this comment.
Reverted in 7982f4a - PNG/JPG/JPEG and other media MIME types are now back in the UI-only block.
main.go
Outdated
Comment on lines
2284
to
2294
| // Register media MIME types for both UI+API and API-only modes | ||
| // (needed for /files/{id} endpoint in all modes) | ||
| mime.AddExtensionType(".png", "image/png") | ||
| mime.AddExtensionType(".jpg", "image/jpg") | ||
| mime.AddExtensionType(".jpeg", "image/jpeg") | ||
| mime.AddExtensionType(".heic", "image/heic") | ||
| mime.AddExtensionType(".heif", "image/heif") | ||
| mime.AddExtensionType(".gif", "image/gif") | ||
| mime.AddExtensionType(".mov", "video/quicktime") | ||
| mime.AddExtensionType(".ico", "image/vnd.microsoft.icon") | ||
|
|
Owner
There was a problem hiding this comment.
We don't actually need to add this afaik, the AddExtensionType below is just a workaround for UI assets on Windows
Contributor
Author
There was a problem hiding this comment.
Removed the separate media MIME block in 7982f4a - all MIME types remain in the UI-only conditional as a Windows workaround.
Co-authored-by: SmilyOrg <1451391+SmilyOrg@users.noreply.github.com>
Copilot
AI
changed the title
Fix MIME registration, FFmpeg guidance, and changelog clarity for HEIC/HEIF/GIF/MOV support
Fix FFmpeg guidance and changelog clarity for HEIC/HEIF/GIF/MOV support
Jan 26, 2026
SmilyOrg
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on PR #171 for HEIC/HEIF/GIF/MOV format support.
Changes
FFmpeg version consistency: Aligned Dockerfile comment with docs (v7.0+ recommended). Clarified that HEVC/H.265 decoder and libheif codec support are required, not just a specific version.
Changelog wording: Changed "fully supported" to "supported when FFmpeg is available" to accurately reflect the conditional nature of format support.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.