Skip to content

Conversation

@benbennett
Copy link

Must use ios::binary because in-memory string uses LF

@lassoan
Copy link
Contributor

lassoan commented Feb 8, 2026

Thank you, it looks good to me, except a small but important thing. Github discussions may be lost in the future (e.g., if the repository has to be moved to a different provider), therefore useful/important information must be saved in the source code or commit comments.

In this case, rationale for the change (explanation of the code) is only in the Github discussion. Please add a comment like // Must use ios::binary because in-memory string uses LF and CR/LF would be used on Windows in non-binary mode to the source code. It is also useful to add some high-level information about a commit (motivation, overall design, etc.). In this case, it would describe why the change was made (e.g., to fix the mechanism that makes repeated builds faster).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants