Fix refreshing of OAuth2 tokens in Sentry 9+#16
Open
stanhu wants to merge 1 commit intoSkyLothar:masterfrom
Open
Fix refreshing of OAuth2 tokens in Sentry 9+#16stanhu wants to merge 1 commit intoSkyLothar:masterfrom
stanhu wants to merge 1 commit intoSkyLothar:masterfrom
Conversation
Sentry has a background job that checks the state of all OAuth2 identities. If the OAuth2 refresh protocol doesn't work, it marks the identity as needing to reauthenticate. The refresh protocol was failing because the `client_id` and `client_secret` were not set in https://github.com/getsentry/sentry/blob/8f717ad1198aa1549bf799b72efe880704f1c6fc/src/sentry/auth/providers/oauth2.py#L153-L154.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sentry has a background job that checks the state of all OAuth2
identities. If the OAuth2 refresh protocol doesn't work, it marks the
identity as needing to reauthenticate.
The refresh protocol was failing because the
client_idandclient_secretwere not set inhttps://github.com/getsentry/sentry/blob/8f717ad1198aa1549bf799b72efe880704f1c6fc/src/sentry/auth/providers/oauth2.py#L153-L154.