client: Create a new HTTP session for each request#10
Open
underyx wants to merge 2 commits intoSkyLothar:masterfrom
Open
client: Create a new HTTP session for each request#10underyx wants to merge 2 commits intoSkyLothar:masterfrom
underyx wants to merge 2 commits intoSkyLothar:masterfrom
Conversation
The globally shared connection resets after some time. When it's reset, the web worker will optimistically try to use it anyway, and fail with a connection error. WIth many web workers running behind a load balancer, this means that a huge portion of login requests would randomly land on a broken session and it was common for people to need to retry 3-4 times until their login attempt finally worked. You can see here how within the sentry project's own code, sessions are created on demand instead of being shared globally: https://github.com/getsentry/sentry/blob/27cc0fed47732dec907668a4529ca39bb384bf5a/src/sentry/http.py#L271
It's not available for instance for the following RequestException:
ConnectionError(ProtocolError('Connection aborted.', error("(104, 'ECONNRESET')",)),)
Author
|
@SkyLothar are you still active? Any chance to get this merged and released officially? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The globally shared connection resets after some time. When it's reset, the web worker will optimistically try to use it anyway, and fail with a connection error.
WIth many web workers running behind a load balancer, this means that a huge portion of login requests would randomly land on a broken session and it was common for people to need to retry 3-4 times until their login attempt finally worked.
You can see here how within the sentry project's own code, sessions are created on demand instead of being shared globally: https://github.com/getsentry/sentry/blob/27cc0fed47732dec907668a4529ca39bb384bf5a/src/sentry/http.py#L271