AIGEN Use BuildKit cache mounts for package manager caches #1087
+49
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace explicit apt cache cleanup with --mount=type=cache. Cache volumes persist between builds for faster rebuilds but are never included in image layers. Also add ca-certificates explicitly since --no-install-recommends skips it, and it's needed for HTTPS access to apt.llvm.org. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace explicit cache cleanup with --mount=type=cache for apt, npm, and SDKMAN archives. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace explicit cache cleanup with --mount=type=cache for apt, npm, and pip caches. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace explicit Gradle cache cleanup with --mount=type=cache. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace explicit cache cleanup with --mount=type=cache for apt and npm caches. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Nodesource's nodejs package bundles npm. Installing Ubuntu's separate npm package alongside it causes conflicts. Remove the explicit npm from apt-get install. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mbouaziz
changed the title
With --no-install-recommends, ca-certificates is not pulled in automatically. Without it, wget can't fetch the nodesource setup script over HTTPS, causing apt to fall back to Ubuntu's nodejs 18 which doesn't include npm. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use TARGETARCH in cache mount IDs to prevent cross-architecture contamination when building for multiple platforms sequentially. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
apt-get clean,npm cache clean,pip cache purge,rm -rf ~/.gradle) with BuildKit--mount=type=cache--no-install-recommendsto all apt-get install callsca-certificatesexplicitly for HTTPS apt repos (needed with--no-install-recommends)npmexplicitly alongsidenodejs(recommended dep, skipped with--no-install-recommends)Files changed
skiplang/Dockerfile— apt cache mountssql/Dockerfile— apt, npm, SDKMAN cache mountsDockerfile— apt, npm, pip cache mountssql/server/core/Dockerfile— Gradle cache mountsql/server/dev/Dockerfile— Gradle cache mountskipruntime-ts/tests/native_addon/Dockerfile— apt, npm cache mountsskipruntime-ts/tests/native_addon_unreleased/Dockerfile— apt, npm cache mountsMeasured impact (skiplang/Dockerfile base stage)
apt-get cleanNotes
--mount=type=cacherequires BuildKit (default since Docker 23.0, Jan 2023)release_docker.shalready usesdocker buildx build(full BuildKit)--no-cacheflag in build scripts disables layer caching but does NOT affect cache mount volumessharing=lockedprevents cache corruption during parallel buildsTest plan
docker build --no-cache -f skiplang/Dockerfile --target base .— builds successfullyclang --version— LLVM 20.1.8 works/var/lib/apt/lists/)🤖 Generated with Claude Code