Skip to content

Fall back to English plural rules instead of crashing on unknown locale #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jacobras wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fall back to English plural rules instead of crashing on unknown locale #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/LOCALIZATION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ in JVM 3rd-party library is used. But in Apple this API is closed and in JS it's
so to avoid burdening the library with heavy solutions, "out of the box" only rules are provided
for [some languages](../libres-core/src/appleAndJsMain/kotlin/io/github/skeptick/libres/strings/PluralRules.kt).

If there are no rules provided for a language, the library falls back to the English rules.

You can create a Pull Request with the required languages or define these values at runtime:

```kotlin
Expand Down
2 changes: 1 addition & 1 deletion libres-core/src/appleAndJsMain/kotlin/io/github/skeptick/libres/strings/PluralRules.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ object PluralRules {
"uk" -> Ukrainian
"kk" -> Kazakh
"fr" -> French
else -> custom[languageCode] ?: error("Plural rule for '$languageCode' not provided")
else -> custom[languageCode] ?: English
Copy link
Author

@jacobras jacobras Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to add some logging here, but there's no logging mechanism in the library currently.

}
}

Expand Down