-
Notifications
You must be signed in to change notification settings - Fork 27
ISO/IEC 19794-2:2005 Template IO #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: image-to-template-test
Are you sure you want to change the base?
Conversation
Currently commented out as it core dumps.
|
Just realised we're not updating the template length in the file once we know it... |
|
Good to be merged now... |
|
FWIW, running this through Pointing to line 117 in |
|
Oh FFS! Turns out that on cygwin at least, the Unity TEST_SETUP stuff wasn't being called, so the template that was being written to disk was bogus. It's now failing on the Import portion of the test... |
This reverts commit 0511010.
|
@andrew-farries @cjheppell so @david-connell and I have fixed it to run under cygwin and fixed the resulting memory leaks. With the memory leak stuff that @fffej did, we hope this means this is now good to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to use const consistently? I'd have thought both should be const in this situation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea, we need to decide on a few things like that and then apply them to all the code in another branch I think...
Import/Export methods for reading/writing ISO templates from SourceAFIS.