Skip to content

Conversation

@alexandr-simprints
Copy link
Contributor

JIRA ticket
Will be released in: 2025.4.0

Root cause analysis (for bugfixes only)

First known affected version: 2025.4.0
There were no OneToOneEvent instances for credential matches.

Notable changes

Now, when a biometric probe that, linked to the credential, is being matched against a biometric probe taken during the workflow, a OneToOne match event is saved.

Testing guidance

  • Enrol a subject A with a credential C
  • Identify biometrics of subject B, and use the same credential C
  • Make sure OneToOne event is created with low confidence score

Additional work checklist

  • Effect on other features and security has been considered
  • Other teams notified about the changes (if applicable)

Copy link
Collaborator

@ybourgery ybourgery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the timestamp are not the most accurate to represent what is actually happening

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

…hCandidatesUseCase to properly reflect the start and end time
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

MatchEntry(subjectId, confidence)
},
fingerComparisonStrategy = if (match.isFaceMatch) null else getFingerprintComparisonStrategy(match.fingerprintBioSdk!!),
probeBiometricReferenceId = match.probeReferenceId.orEmpty(),
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using orEmpty() on probeReferenceId silently converts null to an empty string. Consider whether an empty string is semantically correct for this field, or if null should be preserved or handled differently. If an empty string is intentional when the value is absent, this is acceptable.

Suggested change
probeBiometricReferenceId = match.probeReferenceId.orEmpty(),
probeBiometricReferenceId = match.probeReferenceId,

Copilot uses AI. Check for mistakes.
@sonarqubecloud
Copy link

@alexandr-simprints alexandr-simprints merged commit 1739021 into release/2025.4.0 Jan 14, 2026
13 checks passed
@alexandr-simprints alexandr-simprints deleted the MS-1290-mfid-matching-with-existing-credential-does-not-create-match-events branch January 14, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants