-
-
Notifications
You must be signed in to change notification settings - Fork 1
Replace discovery with a new explore app #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+4,945
−2,281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove redundant and outdated documentation files: - Delete DOCUMENTATION-UPDATE-SUMMARY.md (temporary summary) - Delete extractor-consistency-fixes.md (implementation log) - Delete mypy-precommit-differences.md (resolved issue) - Delete s3-listing-fix.md (implementation detail) - Delete logging-configuration.md (consolidated) Consolidate logging documentation: - Merge logging-configuration.md into logging-guide.md - Create comprehensive guide covering configuration and best practices - Include environment variables, log levels, emoji patterns, and examples Update documentation index: - Remove references to deleted files - Update logging guide description - Update last modified date to 2026-02-12 Results: - Reduced from 35 to 30 documentation files - Eliminated duplicate content - Improved documentation structure and maintainability Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Remove all discovery proxy endpoints, JS methods, HTML sections, and CSS from the dashboard (service count 4→3) - Create new explore service with interactive graph visualization (D3.js) and trends charts (Plotly.js) on port 8006/8007 - Add FastAPI backend with autocomplete, explore, expand, node details, and trends endpoints backed by Neo4j Cypher queries - Add ExploreConfig to common, Dockerfile, docker-compose service, justfile recipes, and update-project.sh - Add 72 unit/API tests and 9 E2E test cases for explore - Update dashboard tests to reflect discovery removal - Update README.md, CLAUDE.md, and add explore/README.md Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The coverage-monitor-action needs statuses:write to create commit status checks. This permission was already passed by build.yml when calling the workflow, but was missing from the workflow's own permissions block for direct PR triggers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add unit tests for lifespan, get_health_data, _get_cache_key, cache eviction, service-not-ready paths, and all not-found paths - Add neo4j_indexes test file covering create_index/create_all_indexes - Expand E2E tests from 9 to 27 (API endpoints, search interactions) - Fix test app static file serving (mount at root with html=True) - Fix validate-compose: add explore to expected services and security checks - Fix E2E coverage: scope to dashboard+explore, run unit tests first to establish 96% baseline before E2E tests append Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add explore to all CI workflows so it's treated like every other service: - Add explore to project matrix (list-sub-projects.yml) for Dockerfile validation and Docker image builds - Add test-explore job to test.yml with coverage upload to Codecov - Add explore to aggregate-results in test.yml - Add explore package install to code-quality.yml for linting/typecheck - Skip discovery Docker build test (>3GB ML deps cause timeout) since discovery is being sunset in favor of explore Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ience - Generate coverage.xml and coverage.json in test-explore job using --cov=explore with xml/json/term reports - Add jq-based coverage-summary.json processing step to test-explore, matching the pattern used in e2e-test.yml - Guard E2E coverage processing with file existence check so the step doesn't fail when tests are skipped (e.g., Playwright install failure) - Add fail_ci_if_error: false to explore Codecov upload Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.