-
Notifications
You must be signed in to change notification settings - Fork 22
Feat/ha plugin #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
AnkushMalaker
wants to merge
12
commits into
dev
Choose a base branch
from
feat/ha-plugin
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feat/ha plugin #248
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a20c1d7
Refactor configuration management in wizard and ChronicleSetup
AnkushMalaker ad4b1f9
Fix string formatting for error message in ChronicleSetup
AnkushMalaker ff061e0
Enhance chat configuration management and UI integration
AnkushMalaker bdcb547
Merge branch 'dev' into feat/edit-chat-system-prompt
AnkushMalaker 5f8d868
Refactor backend shutdown process and enhance chat service configurat…
AnkushMalaker 5a3f8be
Implement plugin system for enhanced functionality and configuration …
AnkushMalaker 32d541f
Enhance configuration management and plugin system integration
AnkushMalaker 251010a
Implement Redis integration for client-user mapping and enhance wake …
AnkushMalaker eceb633
Refactor Deepgram worker management and enhance text normalization
AnkushMalaker 916135e
Add original prompt retrieval and restoration in chat configuration test
AnkushMalaker 944fc62
Refactor test execution and enhance documentation for integration tests
AnkushMalaker 952d471
Enhance test environment cleanup and improve Deepgram worker management
AnkushMalaker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoded Tailscale IP address will not work for other users.
Line 26 contains a hardcoded IP address
100.99.62.5:8123which appears to be a specific Tailscale node. This will break for any other deployment. Consider making this configurable via an environment variable:🔎 Suggested fix
command: > sh -c "tailscaled & tailscale up --authkey=$${TS_AUTHKEY} --accept-dns=true && apk add --no-cache socat 2>/dev/null || true && - socat TCP-LISTEN:18123,fork,reuseaddr TCP:100.99.62.5:8123" + socat TCP-LISTEN:18123,fork,reuseaddr TCP:${HA_TAILSCALE_HOST:-100.99.62.5}:${HA_PORT:-8123}"Also, using
tailscale/tailscale:latestmay cause unexpected behavior after image updates. Consider pinning to a specific version. Per coding guidelines for docker-compose files, this is a maintainability concern.📝 Committable suggestion
🤖 Prompt for AI Agents